refactor(elements): update with latest source changes #16205
Conversation
MayaKirova
added
the
✅ status: verified
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Angular Elements implementation to align with the latest source changes from @angular/elements, updating the change detection strategy and improving the component initialization flow.
- Updates copyright and license information to match Angular's current format
- Replaces custom change detection logic with Angular's new scheduler-based approach
- Simplifies input handling by using the new
setInputAPI instead of manual property assignment
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ng-element-strategy.ts | Major refactor to use Angular's scheduler-based change detection and simplified input handling |
| custom-strategy.ts | Updates to maintain compatibility with the refactored base strategy class |
Comments suppressed due to low confidence (1)
projects/igniteui-angular-elements/src/app/ng-element-strategy.ts:1
- This TODO comment appears to reference specific implementation details without explaining the complete context or timeline for resolution. Consider providing more detail about when this temporary solution will be addressed.
/* eslint-disable @typescript-eslint/explicit-member-accessibility */
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ɵmarkForRefresh as markForRefresh, | ||
| OutputRef, |
There was a problem hiding this comment.
Using private Angular APIs (ɵ-prefixed) creates a risk of breaking changes in future Angular versions. Consider if there are public APIs available or document this dependency carefully.
| ɵmarkForRefresh as markForRefresh, | |
| OutputRef, | |
| ChangeDetectorRef, |
| @@ -1,11 +1,11 @@ | |||
| import { ApplicationRef, ChangeDetectorRef, ComponentFactory, ComponentRef, DestroyRef, EventEmitter, Injector, OnChanges, QueryList, Type, ViewContainerRef, reflectComponentType } from '@angular/core'; | |||
| import { ApplicationRef, ComponentFactory, ComponentRef, DestroyRef, EventEmitter, Injector, QueryList, Type, ViewContainerRef, reflectComponentType } from '@angular/core'; | |||
There was a problem hiding this comment.
Unused imports should be removed. ChangeDetectorRef and OnChanges were removed from the import but other potentially unused imports like DestroyRef, QueryList, and reflectComponentType remain.
| import { ApplicationRef, ComponentFactory, ComponentRef, DestroyRef, EventEmitter, Injector, QueryList, Type, ViewContainerRef, reflectComponentType } from '@angular/core'; | |
| import { ApplicationRef, ComponentFactory, ComponentRef, EventEmitter, Injector, Type, ViewContainerRef } from '@angular/core'; |
Co-authored-by: Copilot <[email protected]>
…tegy.ts" This reverts commit 03fdc47.
Closes #
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)